Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Japanese translation #5816

Merged

Conversation

Tomoya-Matsubara
Copy link
Contributor

Description

Closes #5815

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Checked that the UI works with the Japanese language by setting the language in the local environment. Used docker-compose.yaml for backend.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@Tomoya-Matsubara Tomoya-Matsubara marked this pull request as ready for review February 23, 2025 08:09
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @Tomoya-Matsubara !

@frascuchon frascuchon merged commit 1b7c1cb into argilla-io:develop Mar 10, 2025
2 checks passed
@Tomoya-Matsubara Tomoya-Matsubara deleted the feature/add-japanese-frontend branch March 10, 2025 08:43
frascuchon pushed a commit that referenced this pull request Mar 10, 2025
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

Closes #5815

**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- New feature (non-breaking change which adds functionality)

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

Checked that the UI works with the Japanese language by setting the
language in the local environment. Used
[docker-compose.yaml](https://github.com/argilla-io/argilla/blob/9bc5f101790a8d901884d2ba52a60f7b8f354f38/examples/deployments/docker/docker-compose.yaml)
for backend.

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Japanese Translation
2 participants