-
Notifications
You must be signed in to change notification settings - Fork 140
feat: GetAppDetails function in templates/triggers #155
Conversation
Hi @alexmt I fixed the problem with the tests (sorry I didn't write test but I'm not comfortable enough with golang to write tests) but I don't know how to resolve the problem with golangci-lint. |
That looks very solid for a first contribution! Thank you @paydaycay ! looking |
Awesome! I have no comments for code, just formatting nitpicks. Can you please run this command to sort imports:
and one more to regenerate mocks
|
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 53.04% 51.63% -1.42%
==========================================
Files 32 31 -1
Lines 1361 1435 +74
==========================================
+ Hits 722 741 +19
- Misses 508 558 +50
- Partials 131 136 +5
Continue to review full report at Codecov.
|
Thanks @alexmt ! I hope it will be useful for the community. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Hi ! I suggest this PR to add function repo.GetAppDetails to templates/triggers to support loading application details.
Hope the code is clear enough because it's my first time in golang
#150