Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run Linting as a separate job #579

Merged
merged 1 commit into from
Jul 14, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,17 @@ on:
branches:
- 'master'
jobs:

lint-go:
name: Lint Go code
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v1
with:
version: v1.26
args: --timeout 5m
build:
name: Build
runs-on: ubuntu-latest
Expand Down Expand Up @@ -38,12 +48,6 @@ jobs:
- name: Compile all packages
run: make controller plugin

- name: Run golangci-lint
uses: golangci/golangci-lint-action@v1
with:
version: v1.26
args: --timeout 5m

- name: Test
run: go test -failfast -covermode=count -coverprofile=coverage.out ./...

Expand Down