Optimize SparsePolynomial arithmetic operations to reduce cloning #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit optimizes the implementation of arithmetic operations for SparsePolynomial
by eliminating unnecessary cloning in the following methods:
Instead of using the inefficient approach of cloning the entire polynomials and then
performing operations on the clones, this implementation now uses a more efficient
single-pass algorithm similar to the one used in the Add implementation. This approach
avoids unnecessary memory allocations and copies, which should improve performance
especially for large polynomials.
Fixes TODOs in poly/src/polynomial/univariate/sparse.rs.