Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cython functions as Numpy ufuncs #72

Closed
lpsinger opened this issue Apr 17, 2018 · 4 comments · Fixed by #110
Closed

Implement Cython functions as Numpy ufuncs #72

lpsinger opened this issue Apr 17, 2018 · 4 comments · Fixed by #110
Assignees
@astrofrog
Labels
question
Milestone
1.0

Comments

@lpsinger
Copy link
Contributor

This will eliminate the need for all of the manual broadcasting and type checking.

I have written lots of examples in plain C, but there are also examples in Cython.
@lpsinger lpsinger mentioned this issue Apr 17, 2018
Closed
@astrofrog
Copy link
Member

That would be nice! My only hesitation is that we might lose the benefits of multi-threading? (I don't think Numpy applies ufuncs in a multi-threaded way?)

@lpsinger
Copy link
Contributor Author

My only hesitation is that we might lose the benefits of multi-threading? (I don't think Numpy applies ufuncs in a multi-threaded way?)

Sure, you can run ufuncs in multithreaded code. Nothing stops you from releasing the GIL inside your ufunc loop function.

@lpsinger
Copy link
Contributor Author

Actually, looking at the Numpy source code, I kind of think that Numpy itself releases the GIL while it is calling your ufunc loop function.

@astrofrog
Copy link
Member

astrofrog commented Apr 22, 2018 •
edited
Loading

@lpsinger - ok cool! If this is something you fancy working on, please feel free to as I don't know much about ufuncs :)

lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Apr 24, 2018
@lpsinger
WIP: Reimplement core_cython routines as ufuncs
bb48842 
This eliminates the need for much of the explicit broadasting and
type checking.

At the moment, the patch just implements `healpix_to_lonlat_ring`.
I'd like to ask for feedback on the basic approach before
undertaking conversion of the other functions.

Fixes astropy#72.
@lpsinger lpsinger mentioned this issue Apr 24, 2018
Closed
@cdeil cdeil added the question label Apr 24, 2018
@cdeil cdeil added this to the 1.0 milestone Apr 24, 2018
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Apr 24, 2018
@lpsinger
WIP: Reimplement core_cython routines as ufuncs
5d7d23d 
This eliminates the need for much of the explicit broadasting and
type checking.

At the moment, the patch just implements `healpix_to_lonlat`.
I'd like to ask for feedback on the basic approach before
undertaking conversion of the other functions.

Fixes astropy#72.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Apr 24, 2018
@lpsinger
WIP: Reimplement core_cython routines as ufuncs
ce80dbc 
This eliminates the need for much of the explicit broadasting and
type checking.

At the moment, the patch just implements `healpix_to_lonlat`.
I'd like to ask for feedback on the basic approach before
undertaking conversion of the other functions.

Fixes astropy#72.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Apr 24, 2018
@lpsinger
WIP: Reimplement core_cython routines as ufuncs
4c14bb6 
This eliminates the need for much of the explicit broadasting and
type checking.

At the moment, the patch just implements `healpix_to_lonlat`.
I'd like to ask for feedback on the basic approach before
undertaking conversion of the other functions.

Fixes astropy#72.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Apr 24, 2018
@lpsinger
WIP: Reimplement core_cython routines as ufuncs
1a12149 
This eliminates the need for much of the explicit broadasting and
type checking.

At the moment, the patch just implements `healpix_to_lonlat`.
I'd like to ask for feedback on the basic approach before
undertaking conversion of the other functions.

Fixes astropy#72.
@cdeil cdeil mentioned this issue Jun 26, 2018
Merged
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core using Numpy ufuncs
6c4b4b8 
As a result, broadcasting across nside and ipix is supported
automatically. Fixes astropy#72.
@lpsinger lpsinger mentioned this issue Oct 30, 2018
Merged
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core using Numpy ufuncs
a1e073e 
As a result, broadcasting across nside and ipix is supported
automatically. Fixes astropy#72.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core in C using Numpy ufuncs
f307f89 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core in C using Numpy ufuncs
dada4d0 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core in C using Numpy ufuncs
fd06c55 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
WIP: Rewrite core in C using Numpy ufuncs
4e5a708 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 30, 2018
@lpsinger
Rewrite core in C using Numpy ufuncs
6ee0e69 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 31, 2018
@lpsinger
Rewrite core in C using Numpy ufuncs
2f79b1b 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 31, 2018
@lpsinger
Rewrite core in C using Numpy ufuncs
d40d546 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
lpsinger added a commit to lpsinger/astropy-healpix that referenced this issue Oct 31, 2018
@lpsinger
Rewrite core in C using Numpy ufuncs
87bf0c1 
As a result, broadcasting across nside and ipix is supported
automatically.

Fixes astropy#72, closes astropy#75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrofrog astrofrog

Labels
question
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Rewrite core in C using Numpy ufuncs lpsinger/astropy-healpix
3 participants
@astrofrog @lpsinger @cdeil