Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use int64_t consistently in C code #65

Closed
wants to merge 1 commit into from

Conversation

astrofrog
Copy link
Member

Fixes #64

Still a work in progress at this point!

@astrofrog
Copy link
Member Author

Something isn't working right, so I'll need to investigate further, but no time for now

@cdeil
Copy link
Member

cdeil commented Jan 19, 2018

I only see int type changes in the diff. Any idea how that can lead to this change in shape?
https://travis-ci.org/astropy/astropy-healpix/jobs/288279333#L987
Or is this an unrelated change from upstream (i.e. in Numpy or Astropy)?

@astrofrog
Copy link
Member Author

I'm not sure what the failure here is due to. I'm pretty sure it was due to my changes here, I just haven't had a chance to investigate.

@cdeil cdeil mentioned this pull request Apr 24, 2018
@cdeil cdeil added this to the 0.3 milestone Jun 24, 2018
@cdeil
Copy link
Member

cdeil commented Jun 26, 2018

@astrofrog - I'm closing this old PR.
After #92 by @dstndstn there's too many merge conflicts, this will have to be re-applied.

@cdeil cdeil closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants