add io::cursor #167
Merged
add io::cursor #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the |
|
@stjepang yeah, not sure -- I can't get the borrow checker to allow it. If you want to take a look that'd definitely be helpful.
|
|
@yoshuawuyts it needs to use Pin::get_mut Poll::Ready(io::BufRead::fill_buf(&mut self.get_mut().inner))https://github.com/rust-lang-nursery/futures-rs/blob/master/futures-io/src/lib.rs#L599 |
|
@taiki-e that did the trick! -- thanks so much! |
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
yoshuawuyts
force-pushed
the
io-cursor
branch
from
83d7d45 to
3b8e604
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2019
167: add io::cursor r=stjepang a=yoshuawuyts Adds `io::Cursor` and makes it so `io::prelude::*` behaves the way it does in std (so it can actually be implemented - though this might just have been a bug on my side??). Ref #131. Thanks! Co-authored-by: Yoshua Wuyts <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
io::Cursorand makes it soio::prelude::*behaves the way it does in std (so it can actually be implemented - though this might just have been a bug on my side??).Ref #131. Thanks!