fix doc recursion limit #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshua Wuyts <[email protected]>
Merged
k-nasa
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
LGTM!!
Same as here. It will be fixed if #367 is merged.
https://github.com/async-rs/async-std/pull/367/files#diff-b4aea3e418ccdb71239b96952d9cddb6R49
You don't have to wait.
|
@k-nasa nods -- I left some review comments on that earlier though, and it seems there's now merge conflicts. I didn't want to assume you'd be able to resolve this straight away, so I figured I'd fix CI ahead of time. Thanks for that though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix doc recursion limit on master. Building docs currently fails, and this fixes that. Thanks!