Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection constraint #229

Merged
merged 10 commits into from
Dec 4, 2022
Merged

Collection constraint #229

merged 10 commits into from
Dec 4, 2022

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Dec 4, 2022 •
edited
Loading

  • Add the Collection constraint
  • Fix property path display issue with Enumerable objects
  • Prevent Valid constraints within a Composite constraint
  • Better handle/validate groups for Composite constraints
  • Add AVD::Spec::ConstraintValidatorTestCase#expect_validate_value_at to more easily handle validation of nested constraints

@Blacksmoke16
Support exposing keys in Composite constraint
c617cf3
@Blacksmoke16
Add Collection constraint
83e7883 
Make asserting contextual validations more robust in specs
Handle custom enumerables when build violation property path
@Blacksmoke16
Finish up collection specs
a836d22
@Blacksmoke16
Improve violation to_s a bit
1883f08 
Add spec for enumerable/hash bracket notation contexts
@Blacksmoke16
Add test coverage to Composite constraint
03b58c1 
Ensure Valid constraint cannot be used with it
Properly merge/check for excess groups in nested constraints
First pass on collection docs
@Blacksmoke16
Polish the collection docs a bit more
0de4630
@Blacksmoke16
Fix broken link in Compound constraint
29884c0 
Add docs to existence based constraints
@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected component:validator kind:feature Brand new functionality kind:enhancement New functionality to an existing feature breaking labels Dec 4, 2022
@Blacksmoke16 Blacksmoke16 merged commit c678947 into master Dec 4, 2022
@Blacksmoke16 Blacksmoke16 deleted the collection-constraint branch December 4, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component:validator kind:bug An existing feature isn't working as expected kind:enhancement New functionality to an existing feature kind:feature Brand new functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Blacksmoke16