Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip console from builds #309

Merged
merged 2 commits into from
Feb 5, 2018
Merged

strip console from builds #309

merged 2 commits into from
Feb 5, 2018

Conversation

ajaymathur
Copy link
Member

@alexreardon
Copy link
Collaborator

Great outcome @ajaymathur !!

Just to confirm everything is working, can you please confirm the size of the existing bundle compared to the new one?

To get the minified value - run yarn run build
To get the gzip value - right click on the file in macosx and click 'compress'. This is roughly correct

@ajaymathur
Copy link
Member Author

Stats

Matrix With logs (before) After striping logs Reduction
min 141066 135245 5821
gzip 37111 35726 1385

*all numbers in bytes

@alexreardon alexreardon merged commit fd34409 into atlassian:master Feb 5, 2018
@alexreardon
Copy link
Collaborator

Love it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreardon alexreardon alexreardon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajaymathur @alexreardon