Screen reader support #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
commented
Feb 8, 2018
| @@ -564,6 +566,29 @@ Here are a few poor user experiences that can occur if you change things *during | |||
| - If you remove the node that the user is dragging, then the drag will instantly end | |||
| - If you change the dimension of the dragging node, then other things will not move out of the way at the correct time. | |||
|
|
|||
| ### Accessibility ❤️ | |||
| @@ -1,143 +0,0 @@ | |||
| // @flow | |||
There was a problem hiding this comment.
moved to new file
| const previousPhase = previous.phase; | ||
|
|
||
| // Dragging in progress | ||
| if (currentPhase === 'DRAGGING' && previousPhase === 'DRAGGING') { |
There was a problem hiding this comment.
processing for a new hook - onDragUpdate 👍
src/types.js
Outdated
| onDragStart?: (start: DragStart) => void, | ||
| onDragEnd: (result: DropResult) => void, | ||
| onDragStart?: (start: DragStart, announce: Announce) => void, | ||
| onDragUpdate?: (update: DragUpdate, announce: Announce) => void, |
src/types.js
Outdated
| export type Hooks = {| | ||
| onDragStart?: (start: DragStart) => void, | ||
| onDragEnd: (result: DropResult) => void, | ||
| onDragStart?: (start: DragStart, announce: Announce) => void, |
There was a problem hiding this comment.
all hooks now provided with a second argument: announce
This is used to announce text to screen readers
| @@ -7,7 +7,8 @@ import { quotes, getQuotes } from './src/data'; | |||
| import { grid } from './src/constants'; | |||
|
|
|||
| const data = { | |||
| small: quotes, | |||
| // small: quotes, | |||
stories/src/accessible/task-app.jsx
Outdated
| tasks: Task[] | ||
| |} | ||
|
|
||
| const getPosition = (index: number, length: number): string => ` |
There was a problem hiding this comment.
This wording feels a little dry
| @@ -15,7 +15,7 @@ type Props = { | |||
|
|
|||
| type HTMLElement = any; | |||
|
|
|||
| const Container = styled.a` | |||
| const Container = styled.div` | |||
| @@ -40,7 +40,11 @@ export default class QuoteApp extends Component<Props, State> { | |||
| quotes: this.props.initial, | |||
| }; | |||
|
|
|||
| onDragStart = (initial: DragStart) => { | |||
| onDragStart = (initial: DragStart, announce: Announce) => { | |||
There was a problem hiding this comment.
we can remove the announcement stuff from this example and leave it in the new story
|
This build will never go green as auto-scroller is also red. Once we are happy with this we can merge it into that branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding proper screen reader support
Closes #7
Partially completes #298 (adds onDragUpdate)