Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to babel-preset-env #325

Closed
wants to merge 0 commits into from
Closed

update to babel-preset-env #325

wants to merge 0 commits into from

Conversation

alirezavalizade
Copy link

No description provided.

@alexreardon
Copy link
Collaborator

We support a [range of browers]. We would need to instruct babel-preset-env about what browsers we are using using a browserlist. We could not just use the default.

Given that we support ie11 using babel-preset-2015 is sufficient for now. However, I am happy to proceed with this if you are willing to add the correct browser list 👍

@alirezavalizade
Copy link
Author

@alexreardon Please check this.

@alexreardon
Copy link
Collaborator

Hi @alirezavalizade, I think it is better to be a little more explicit to match our browser matrix. Here is what we are using in other products:

ie >= 11
last 1 Edge version
last 1 Firefox version
last 1 Chrome version
last 1 Safari version
last 1 iOS version
last 1 Android version
last 1 ChromeAndroid version

If you can add that we should be good to go!

@alirezavalizade
Copy link
Author

alirezavalizade commented Feb 16, 2018

@alexreardon Hi, Great.
Thanks for browser matrix!

@alexreardon
Copy link
Collaborator

I'll check this tomorrow and ensure it is working correctly

Then we should be gewd

@alexreardon
Copy link
Collaborator

I have not forgotten about this. I am just focusing on the moment on shipping #321. I hope to merge this for 5.0

@alexreardon
Copy link
Collaborator

Whoops - i think i messed this up by trying to add a commit

@alirezavalizade
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants