This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Resize tabs when mouse moves away from tab bar #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good! Would you mind adding some kind of transition to the tabs so they don't just pop to their new size? |
danjordan
changed the title
|
Not sure if you got a notification when I pushed the code, so just letting you know I have added an animation when the tabs move back to max-height. |
|
Any updates on this feature? |
| @@ -17,6 +17,7 @@ | |||
| -webkit-flex: 1; | |||
| max-width: 175px; | |||
| min-width: 40px; | |||
| transition: max-width .25s ease-in; | |||
There was a problem hiding this comment.
Not too critical, but how about ease-in-out? Then it doesn't stop too abruptly.
|
Tried it out and UX-wise it works great, especially for even sized tabs. 👍
|
|
This was added in #344 – thanks again for all your hard work @danjordan! 👏 |
|
This should land in Atom 1.10 |
|
@danjordan this is the best feature to land in Atom since the first release :D |
This was referenced Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation of the Chrome tabs functionality required in issue #129.
Functionality added...