Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed userStore from WebStorageStateStore to StateStore #1851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed userStore from WebStorageStateStore to StateStore #1851

wants to merge 1 commit into from

Conversation

sebastienlabine
Copy link

@sebastienlabine sebastienlabine commented Feb 15, 2025 •
edited
Loading

Closes/fixes #1850

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa
Copy link
Member

pamapa commented Mar 3, 2025

looks good, but please only change the type and leave the formatting changes away...

@pamapa
Copy link
Member

pamapa commented Mar 3, 2025 •
edited
Loading

and pipeline fails with:

Using configuration from ./api-extractor.json
Analysis will use the bundled TypeScript version 5.7.2
Warning: You have changed the API signature for this project. Please copy the file "temp/oidc-client-ts.api.md" to "docs/oidc-client-ts.api.md", or perform a local build (which does this automatically). See the Git repo documentation for more info.

API Extractor completed with warnings

@sebastienlabine
Copy link
Author

@pamapa will fix! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

userStore should be StateStore instead of WebStorageStateStore allowing custom implementation
2 participants
@sebastienlabine @pamapa