Introduce event segment to store multiple events under one key #25
+242
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
StorageValue
theEvents
is a single array in the state that keep growing as more extrinsic is executed and more events append to this array, which makes execution and storage root calculation slower and slower as allocation/copying/hashing this array takes more and more time.This PR introduces event segment to store multiple events under one key in a
StorageMap
. The size of the segment is defined by a new config itemEventSegmentSize
, while a larger segment leads toward the same issue as theStorageValue
Events
, a smaller segment brings more items to the Trie and may impact performance. From the benchmark result 100 maybe a good parameter for us.Also, when
EventSegmentSize
is set to zero the event segment is disabled to avoid unexpected breaking change.