Virtual disk: add 2 new datastore cases

Automate two cases:
VIRT-303298 [virtual disks][dataStore] Hotplug/unplug disks with data files
VIRT-303297 [virtual_disks][dataStore] Start guest with disks that have data files

Signed-off-by: Meina Li <[email protected]>

libvirt/tests/cfg/virtual_disks/virtual_disks_datastore.cfg

@@ -0,0 +1,16 @@
+- virtual_disks.datastore:
+    type = virtual_disks_datastore
+    start_vm = no
+    target_disk = "vdb"
+    disk_type = "file"
+    func_supported_since_libvirt_ver = (10, 10, 0)
+    data_file_option = " -o data_file=%s"
+    disk_dict = {"type_name":"${disk_type}", "target":{"dev": "${target_disk}", "bus": "virtio"}, "driver": {"name": "qemu", "type":"qcow2"}}
+    variants:
+        - start_vm:
+        - hotplug_disk:
+            with_hotplug = "yes"
+    variants datastore_type:
+        - with_file:
+        - with_block:
+            with_block = "yes"

libvirt/tests/src/virtual_disks/virtual_disks_datastore.py

@@ -0,0 +1,97 @@
+import os
+
+from virttest import data_dir
+from virttest import libvirt_version
+from virttest import utils_disk
+from virttest import virsh
+from virttest.libvirt_xml import vm_xml
+from virttest.utils_libvirt import libvirt_disk
+from virttest.utils_libvirt import libvirt_vmxml
+from virttest.utils_test import libvirt
+
+from provider.virtual_disk import disk_base
+
+
+def run(test, params, env):
+    """
+    Start guest with datastore and hotplug disk with datastore.
+    """
+    def prepare_disk():
+        """
+        Prepare the disk.
+
+        :params return: return the data file of new image.
+        """
+        if with_block:
+            data_file = libvirt.setup_or_cleanup_iscsi(is_setup=True, is_login=True)
+        else:
+            data_file = data_dir.get_data_dir() + '/datastore.img'
+            libvirt.create_local_disk("file", data_file, "50M", "raw")
+        return data_file
+
+    def hotplug_disk(data_file_option):
+        """
+        Hotplug disk device.
+
+        :params data_file_option: the option to create image with data file
+        :params return: return the new image path
+        """
+        if not vm.is_alive():
+            vm.start()
+        _, new_image_path = disk_obj.prepare_disk_obj(disk_type, disk_dict, new_image_path="",
+                                                      extra=data_file_option)
+        disk_dict.update({'source': {'attrs': {'file': new_image_path}}})
+        disk_dev = libvirt_vmxml.create_vm_device_by_type("disk", disk_dict)
+        virsh.attach_device(vm_name, disk_dev.xml, debug=True, ignore_status=False, wait_for_event=True)
+        return new_image_path, disk_dev
+
+    def check_result():
+        """
+        Check the test result.
+        """
+        if not vm.is_alive():
+            vm.start()
+        vm_session = vm.wait_for_login()
+        disk_xml = virsh.dumpxml(vm_name, "--xpath //disk", debug=True).stdout_text
+        if "dataStore" not in disk_xml:
+            test.fail("Can't get the datastore element automatically!")
+        test.log.info("TEST_STEP: Do read/write for disk.")
+        new_disk = libvirt_disk.get_non_root_disk_name(vm_session)[0]
+        utils_disk.dd_data_to_vm_disk(vm_session, new_disk)
+        vm_session.close()
+
+    vm_name = params.get("main_vm")
+    vm = env.get_vm(vm_name)
+    disk_dict = eval(params.get('disk_dict', '{}'))
+    disk_type = params.get("disk_type")
+    with_hotplug = "yes" == params.get("with_hotplug", "no")
+    with_block = "yes" == params.get("with_block", "no")
+    libvirt_version.is_libvirt_feature_supported(params)
+
+    vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)
+    vmxml_backup = vmxml.copy()
+    disk_obj = disk_base.DiskBase(test, vm, params)
+
+    try:
+        test.log.info("TEST_STEP: Prepare the guest.")
+        data_file = prepare_disk()
+        data_file_option = params.get("data_file_option") % data_file
+        if with_hotplug:
+            test.log.info("TEST_STEP: Hotplug disk with datastore.")
+            new_image_path, disk_dev = hotplug_disk(data_file_option)
+        else:
+            new_image_path = disk_obj.add_vm_disk(disk_type, disk_dict, new_image_path="",
+                                                  extra=data_file_option)
+        test.log.info("TEST_STEP: Check the disk dumpxml.")
+        check_result()
+        if with_hotplug:
+            virsh.detach_device(vm_name, disk_dev.xml, debug=True, ignore_status=False,
+                                wait_for_event=True)
+    finally:
+        vmxml_backup.sync()
+        disk_obj.cleanup_disk_preparation(disk_type)
+        if with_block:
+            libvirt.setup_or_cleanup_iscsi(is_setup=False)
+        for file in [new_image_path, data_file]:
+            if os.path.exists(file):
+                os.remove(file)

spell.ignore

@@ -1259,3 +1259,4 @@ Meina
 meili
 ntp
 userfaultfd
+datastore