Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update to golangci-lint version compatible with go 1.23 #3739

Merged
merged 1 commit into from
Feb 22, 2025
Merged

[ci] Update to golangci-lint version compatible with go 1.23 #3739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ run:
build-tags:
- test

output:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is in response to the newer version of golangci-lint complaining thus:

^[[33mWARN^[[0m [config_reader] The configuration option `output.uniq-by-line` is deprecated, please use `issues.uniq-by-line`

issues:
# Make issues output unique by line.
# Default: true
uniq-by-line: false

issues:
# Maximum issues count per one linter.
# Set to 0 to disable.
# Default: 50
Expand Down
2 changes: 1 addition & 1 deletion scripts/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ fi
TESTS=${TESTS:-"golangci_lint license_header require_error_is_no_funcs_as_params single_import interface_compliance_nil require_no_error_inline_func import_testing_only_in_tests"}

function test_golangci_lint {
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.2
go install -v github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.5
golangci-lint run --config .golangci.yml
}

Expand Down
Loading