Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Simplify log and metric collection #1440

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Feb 2, 2025

Why this should be merged

Update to use the avalanchego nix flake to install promtail and prometheus and have tmpnet run them, removing the need for the run_prometheus.sh and run_promtail.sh scripts.

How this works

  • Adds a nix flake that inherits its shell from the avalanchego flake
  • Updates CI jobs to the new version of the run-monitored-tmpnet-cmd action

How this was tested

CI

Need to be documented?

Existing reference to tmpnet docs updated by ava-labs/avalanchego#3692 will hopefully suffice.

Need to update RELEASES.md?

N/A

TODO

@maru-ava maru-ava added ci testing This primarly focuses on testing labels Feb 2, 2025
@maru-ava maru-ava self-assigned this Feb 2, 2025
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 3 times, most recently from 1a36ad9 to 311e118 Compare February 4, 2025 18:30
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from 311e118 to a86ebfa Compare February 22, 2025 19:56
@maru-ava maru-ava changed the base branch from master to bump-golang-1.23.6 February 22, 2025 19:58
Base automatically changed from bump-golang-1.23.6 to master February 24, 2025 14:41
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 5 times, most recently from 5418bea to bc72b5f Compare February 24, 2025 22:58
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 2 times, most recently from c8011b6 to a2605de Compare March 4, 2025 22:02
@maru-ava maru-ava marked this pull request as ready for review March 4, 2025 22:02
@maru-ava maru-ava requested review from ceyonur, darioush and a team as code owners March 4, 2025 22:02
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from a2605de to a621c2a Compare March 4, 2025 22:03
@maru-ava maru-ava marked this pull request as draft March 4, 2025 22:06
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 6 times, most recently from 371a4c7 to c405f18 Compare March 5, 2025 17:51
@maru-ava maru-ava changed the base branch from master to set-avalanchego-version March 5, 2025 17:52
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from 182a525 to 7a04c56 Compare March 5, 2025 18:46
@maru-ava maru-ava force-pushed the set-avalanchego-version branch from dc80f47 to 8f2402b Compare March 5, 2025 20:35
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from 7a04c56 to ddceac0 Compare March 5, 2025 20:39
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch 2 times, most recently from 7975403 to cc2b433 Compare March 5, 2025 21:19
maru-ava added 4 commits March 5, 2025 22:46
Previously it was necessary to manually maintain the avalanchego
version in versions.sh. Now the version is automatically detected from
the go module configuration.
Update to use the avalanchego nix flake to install promtail and
prometheus and have tmpnet run them, removing the need for the
run_prometheus.sh and run_promtail.sh scripts.
@maru-ava maru-ava force-pushed the simplify-ci-monitoring branch from fbbb19f to c8c7e97 Compare March 5, 2025 21:47
Base automatically changed from set-avalanchego-version to master March 10, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci testing This primarly focuses on testing
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

1 participant