-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] Simplify log and metric collection #1440
Draft
maru-ava
wants to merge
4
commits into
master
Choose a base branch
from
simplify-ci-monitoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a36ad9
to
311e118
Compare
311e118
to
a86ebfa
Compare
5418bea
to
bc72b5f
Compare
c8011b6
to
a2605de
Compare
a2605de
to
a621c2a
Compare
371a4c7
to
c405f18
Compare
182a525
to
7a04c56
Compare
dc80f47
to
8f2402b
Compare
7a04c56
to
ddceac0
Compare
7975403
to
cc2b433
Compare
Previously it was necessary to manually maintain the avalanchego version in versions.sh. Now the version is automatically detected from the go module configuration.
Update to use the avalanchego nix flake to install promtail and prometheus and have tmpnet run them, removing the need for the run_prometheus.sh and run_promtail.sh scripts.
fbbb19f
to
c8c7e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Update to use the avalanchego nix flake to install promtail and prometheus and have tmpnet run them, removing the need for the run_prometheus.sh and run_promtail.sh scripts.
How this works
How this was tested
CI
Need to be documented?
Existing reference to tmpnet docs updated by ava-labs/avalanchego#3692 will hopefully suffice.
Need to update RELEASES.md?
N/A
TODO