-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge coreth master (18dee21) #1447
Open
ceyonur
wants to merge
40
commits into
master
Choose a base branch
from
merge-coreth-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,783
−1,274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Darioush Jalali <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
darioush
reviewed
Feb 28, 2025
plugin/evm/header/extra_test.go
Outdated
expected: nil, | ||
}, | ||
{ | ||
name: "subnet_invalid_less", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: subnet_evm
for consistency with above. also below.
darioush
previously approved these changes
Feb 28, 2025
darioush
approved these changes
Feb 28, 2025
ARR4N
approved these changes
Mar 3, 2025
alarso16
approved these changes
Mar 3, 2025
…blocks (#719) - default behavior for pruning mode to reject blocks before the 32 blocks preceding the last accepted block - default behavior for archive mode to reject blocks before ~24h worth of blocks preceding the last accepted block - archive mode new option `historical-proof-query-window` to customize the blocks window, or set it to 0 to accept any block number
Signed-off-by: Darioush Jalali <[email protected]> Co-authored-by: Sina M <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Darioush Jalali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Cherry picks following PRs from Coreth and syncs coreth master up to 18dee21632f4e3c3ebbd259626ecd6e0b21021c5
How this was tested
UT&CI
Need to be documented?
No
Need to update RELEASES.md?
No