This repository was archived by the owner on Mar 13, 2023. It is now read-only.
[types] Add global types from ParallelCluster and weave through code.
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesg3
changed the title
[types] Add global types from ParallelCluster and weave through code.[types] Add global types from ParallelCluster and weave through code.
…used at runtime.
mendaomn
reviewed
Aug 5, 2022
mtfranchetto
reviewed
Aug 8, 2022
mtfranchetto
approved these changes
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the global types from AWS ParallelCluster (and Slurm)
Changes
Leverage the global types to take advantage of type checking.
How Has This Been Tested?
Manual testing.
References
https://github.com/aws/aws-parallelcluster/tree/develop/api/spec/smithy/model
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.