address comments 1

aws · Aug 31, 2023 · 3c6b9e6 · 3c6b9e6
1 parent cc0437a
commit 3c6b9e6
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/agent/data/client.go b/agent/data/client.go
@@ -135,7 +135,7 @@ func setup(dataDir string) (*client, error) {
 	})
 
 	// create transformer
-	transformer := modeltransformer.NewTransFormer()
+	transformer := modeltransformer.NewTransformer()
 
 	// registering task transformation functions
 	transformationfunctions.RegisterTaskTransformationFunctions(transformer)

diff --git a/agent/data/client_test.go b/agent/data/client_test.go
@@ -30,7 +30,7 @@ func newTestClient(t *testing.T) Client {
 	testDir := t.TempDir()
 
 	testDB, err := bolt.Open(filepath.Join(testDir, dbName), dbMode, nil)
-	transformer := modeltransformer.NewTransFormer()
+	transformer := modeltransformer.NewTransformer()
 	require.NoError(t, err)
 	require.NoError(t, testDB.Update(func(tx *bolt.Tx) error {
 		for _, b := range buckets {

diff --git a/agent/data/transformationfunctions/tasktf_test.go b/agent/data/transformationfunctions/tasktf_test.go
@@ -29,7 +29,7 @@ const (
 )
 
 func TestRegisterTaskTransformationFunctions(t *testing.T) {
-	transformer := modeltransformer.NewTransFormer()
+	transformer := modeltransformer.NewTransformer()
 	RegisterTaskTransformationFunctions(transformer)
 	assert.Equal(t, expectedTaskTransformationChainLength, transformer.GetNumberOfTransformationFunctions("Task"))
 }
diff --git a/ecs-agent/modeltransformer/transformer.go b/ecs-agent/modeltransformer/transformer.go
@@ -41,7 +41,7 @@ type TransformFunc struct {
 	function interface{}
 }
 
-func NewTransFormer() *Transformer {
+func NewTransformer() *Transformer {
 	t := &Transformer{}
 	return t
 }
@@ -56,7 +56,7 @@ func (t *Transformer) GetNumberOfTransformationFunctions(modelType string) int {
 	}
 }
 
-// TransformTask executes the transformation functions when version associated with model in boltdb is below the
+// TransformTask executes the transformation functions when version associated with model in boltdb is below the threshold
 func (t *Transformer) TransformTask(version string, data []byte) ([]byte, error) {
 	var err error
 	// execute transformation functions sequentially and skip those not applicable

diff --git a/ecs-agent/modeltransformer/transformer_test.go b/ecs-agent/modeltransformer/transformer_test.go
@@ -131,7 +131,7 @@ func TestAddTaskTransformationFunctionsAndTransformTask(t *testing.T) {
 				TestFieldTaskVCpu:     1,
 			})
 			dataIn, _ := json.Marshal(&tc.dataIn)
-			transformer := NewTransFormer()
+			transformer := NewTransformer()
 			transformer.AddTaskTransformationFunctions(firstThresholdVersion, testTransformationFunction1100)
 			transformer.AddTaskTransformationFunctions(secondThresholdVersion, testTransformationFunction1200)
 			dataOut, err := transformer.TransformTask(tc.boltDbMetadataVersion, dataIn)
@@ -170,7 +170,7 @@ func TestCheckIsUpgrade(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			transformer := NewTransFormer()
+			transformer := NewTransformer()
 			assert.Equal(t, tc.expect, transformer.IsUpgrade(tc.runningAgentVersion, tc.persistedAgentVersion))
 		})
 	}