-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-cloudformation): L2 implementation of AWS::CloudFormation::ResourceVersion #33039
feat(aws-cloudformation): L2 implementation of AWS::CloudFormation::ResourceVersion #33039
Conversation
- CF type https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-resourceversion.html - creates log group + log access role if not provided - param documentation taken from cloudformation docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'cloudformation' instead of 'aws-cloudformation'.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
since this is a basic L2 implementation in an existing service subpackage, I dont believe a README update is necessary nor are integ tests additionally, there is nothing in the README and the there are no integ tests for this subpackage |
Thank you for the PR! However, I don't quite agree with this statement. IMO, we need to add README and integration tests to test the deployability and tell users who to use this new L2 construct. I would kindly ask you to include some integ tests and readme changes. Appreciate it! |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 7 days if no action is taken. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
n/a
Reason for this change
CDK type implementation for the this resource to improve developer experience
Description of changes
L2 implementation of AWS::CloudFormation::ResourceVersion
Describe any new or updated permissions being added
n/a (I believe?)
Description of how you validated changes
yes, added unit test around new construct. open to expanding it further if general approach looks good.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license