Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cloudformation): L2 implementation of AWS::CloudFormation::ResourceVersion #33039

Conversation

695K0C9K1ZZmo6R
Copy link

@695K0C9K1ZZmo6R 695K0C9K1ZZmo6R commented Jan 21, 2025

Issue # (if applicable)

n/a

Reason for this change

CDK type implementation for the this resource to improve developer experience

Description of changes

L2 implementation of AWS::CloudFormation::ResourceVersion

Describe any new or updated permissions being added

n/a (I believe?)

Description of how you validated changes

yes, added unit test around new construct. open to expanding it further if general approach looks good.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- CF type https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-resourceversion.html
- creates log group + log access role if not provided
- param documentation taken from cloudformation docs
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2025 22:18
@github-actions github-actions bot added the p2 label Jan 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'cloudformation' instead of 'aws-cloudformation'.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@695K0C9K1ZZmo6R 695K0C9K1ZZmo6R changed the title l2 imp of AWS::CloudFormation::ResourceVersion feat: L2 implementation of AWS::CloudFormation::ResourceVersion Jan 21, 2025
@695K0C9K1ZZmo6R 695K0C9K1ZZmo6R changed the title feat: L2 implementation of AWS::CloudFormation::ResourceVersion feat(aws-cloudformation): L2 implementation of AWS::CloudFormation::ResourceVersion Jan 21, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d185888
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@695K0C9K1ZZmo6R
Copy link
Author

Exemption Request

since this is a basic L2 implementation in an existing service subpackage, I dont believe a README update is necessary nor are integ tests

additionally, there is nothing in the README and the there are no integ tests for this subpackage

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 21, 2025
@695K0C9K1ZZmo6R 695K0C9K1ZZmo6R marked this pull request as ready for review January 21, 2025 22:49
@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 18, 2025

Exemption Request

since this is a basic L2 implementation in an existing service subpackage, I dont believe a README update is necessary nor are integ tests

additionally, there is nothing in the README and the there are no integ tests for this subpackage

Thank you for the PR! However, I don't quite agree with this statement. IMO, we need to add README and integration tests to test the deployability and tell users who to use this new L2 construct. I would kindly ask you to include some integ tests and readme changes. Appreciate it!

@GavinZZ GavinZZ added pr-linter/no-exemption The requested exemption will not be granted to the PR linter result and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 18, 2025
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 7 days if no action is taken.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 pr-linter/no-exemption The requested exemption will not be granted to the PR linter result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants