Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SSMDefaultUser substack #164

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

BarcoMasile
Copy link
Contributor

Description

The SSMDefaultUser substack has been removed from the main stack, so it doesn't get deployed anymore, and it has been removed from the codebase.

This changes the way customer will experience the Shell action on a cluster with SSM enabled, since the user of the newly presented shell will not be the one specified in the /opt/parallelcluster/cfnconfig file as cfn_cluster_user, but it will be the default SSM user.

How Has This Been Tested?

This has been tested manually by

  • deploying PCUI
  • trying different dry-runs with different configs
  • launching the creation of a cluster with SSM enabled
  • performing miscellaneous actions on the cluster
  • deleting the cluster
  • deleting the whole PCUI stack with no errors

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BarcoMasile BarcoMasile force-pushed the change/remove-ssm-substack branch from 959a42d to 7a5e92d Compare April 4, 2023 15:01
@BarcoMasile BarcoMasile marked this pull request as ready for review April 4, 2023 15:09
Copy link
Contributor

@mtfranchetto mtfranchetto Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: update update.sh and update-environment-infra.sh as well by removing references to this file, otherwise deploys will break!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! I will do asap! Thanks

@BarcoMasile BarcoMasile merged commit 1f4a377 into main Apr 6, 2023
@BarcoMasile BarcoMasile deleted the change/remove-ssm-substack branch April 6, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants