Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate LicenseToken field is not used by other clusters #9222

Merged

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Feb 5, 2025

Issue #, if available:
#6793

Description of changes:
Validate the license token is not being used by multiple clusters for extended kubernetes version support for eks-a controller.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2025
@panktishah26 panktishah26 force-pushed the licenseKey-duplicate-validation branch from 9094f9a to 61c0ae2 Compare February 6, 2025 00:50
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.32%. Comparing base (21b4f95) to head (aa8aa67).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/validations/extendedversion.go 60.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9222   +/-   ##
=======================================
  Coverage   72.31%   72.32%           
=======================================
  Files         587      587           
  Lines       46056    46081   +25     
=======================================
+ Hits        33306    33328   +22     
- Misses      11000    11003    +3     
  Partials     1750     1750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the licenseKey-duplicate-validation branch from 61c0ae2 to aa8aa67 Compare February 6, 2025 01:15
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 30fa933 into aws:main Feb 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants