-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace to external etcd ref #9252
Add namespace to external etcd ref #9252
Conversation
Signed-off-by: EKS Distro PR Bot <[email protected]>
Signed-off-by: EKS Distro PR Bot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9252 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 587 587
Lines 46140 46140
=======================================
Hits 33385 33385
Misses 11006 11006
Partials 1749 1749 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2ez4szliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.21 |
@rahulbabu95: new pull request created: #9261 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
In the etcdadm reconcile loop we make a namespaced lookup for the etcdadm cluster object referenced in the capi cluster. For Cloudstack provider, when we create the capi cluster object we missed referencing the namespace as we do for other providers. This fix adds in the namespace for the external etcd reference.
This was the panic on the etcd controller before the fix:
Testing (if applicable):
Built a new etcd controller and verified that the panic went away during the reconciliation.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.