Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readme #196

Merged
merged 12 commits into from
Feb 27, 2024
Merged

fix: readme #196

merged 12 commits into from
Feb 27, 2024

Conversation

polaschwoebel
Copy link
Contributor

Updates to README.md to address some points in our internal pain points doc.

  • State python version earlier.
  • Remove get_eval_algorithm from example usage as it's no longer recommended.
  • Replaced link to empty doc page with link to developer guide.
  • Added details on devtool.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@polaschwoebel polaschwoebel changed the title Readme fix: readme Feb 21, 2024
README.md Outdated
### Setup
Once a virtual environment is set up with python3.10, run the following command to install all dependencies:
### Setup and the use of `devtool`
Once you have set up virtual environment with python3.10, run the following command to install `devtool`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: For the sake of clarity: change this to "... run the following command to setup the development environment ..." and remove the sentence "Then you can install the library with all dependencies ...". We anyways mention ./devtool all one sentence later (the sentence starting with "Before submitting a PR ...")

@polaschwoebel polaschwoebel merged commit 0f2a7e4 into aws:main Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants