Fix Retries for ECSCredentialsProvider #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Jan 21, 2025
| @@ -71,6 +75,25 @@ struct aws_credentials_provider_ecs_user_data { | |||
| int error_code; | |||
| }; | |||
|
|
|||
| /* called in between retries. */ | |||
| static void s_ecs_user_data_reset_request_specific_data(struct aws_credentials_provider_ecs_user_data *user_data) { | |||
There was a problem hiding this comment.
There's another similarly named pre-existing function in this file: s_aws_credentials_provider_ecs_user_data_reset_response()
What's the difference? Can they be combined? If not, put them next to each other with a comment explaining when you'd call one and not the other.
If there's already some kind of reset function in this file ... did we miss some other flow that should be reporting record_success() (or failure)?
There was a problem hiding this comment.
Thanks, I have removed the other function since it was not needed. We will call the new function between retries to clear the request level data.
graebm
approved these changes
Jan 21, 2025
github-merge-queue bot
pushed a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Jan 23, 2025
Update the CRT to the latest releases. This change also updates the exclude list, primarily due to one of the test files being replaced by a compressed (but still large) file: aws/aws-lc#2123 This change pulls in a bug fix (awslabs/aws-c-auth#259), addressing #1207. ### Does this change impact existing behavior? One bug fix is included in CRT changes. ### Does this change need a changelog entry? Does it require a version change? Change log entry added for the CRT fix. It is a bug fix, so patch version bump to `mountpoint-s3-client` remains appropriate. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
keremnc
pushed a commit
to keremnc/mountpoint-s3
that referenced
this pull request
Jan 24, 2025
Update the CRT to the latest releases. This change also updates the exclude list, primarily due to one of the test files being replaced by a compressed (but still large) file: aws/aws-lc#2123 This change pulls in a bug fix (awslabs/aws-c-auth#259), addressing awslabs#1207. ### Does this change impact existing behavior? One bug fix is included in CRT changes. ### Does this change need a changelog entry? Does it require a version change? Change log entry added for the CRT fix. It is a bug fix, so patch version bump to `mountpoint-s3-client` remains appropriate. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.