Mqtt5to3 adapter #527
Closed
Mqtt5to3 adapter #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
commented
Aug 2, 2023
| @@ -303,7 +338,7 @@ namespace Aws | |||
| { | |||
| auto connection = reinterpret_cast<MqttConnection *>(user_data); | |||
|
|
|||
| Allocator *allocator = connection->m_owningClient->allocator; | |||
| Allocator *allocator = connection->m_allocator; | |||
There was a problem hiding this comment.
m_owningClient is a mqtt3 client. As now the m_owningClient is not necessary set for the case of Mqtt5, use the m_allocator of connection instead of using the allocator from mqtt client.
xiazhvera
commented
Aug 2, 2023
| @@ -460,99 +588,57 @@ namespace Aws | |||
| return nullptr; | |||
| } | |||
|
|
|||
| uint16_t port = m_port; | |||
There was a problem hiding this comment.
Move the section to buildClientOption()
This reverts commit cf53310.
|
Updated PR at #528. Close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bind out the Mqtt5 to Mqtt3 adapter.
(Still need update submodules: awslabs/aws-c-mqtt#313)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.