Skip to content

Commit

Permalink
fix(components): move message merge to componentWillRender()
Browse files Browse the repository at this point in the history
- clean git history and update doc
- removed unused method in `iot-react-table.tsx`
  • Loading branch information
square-li committed Sep 13, 2022
1 parent 0258b8b commit 735bba8
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 9 deletions.
9 changes: 6 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# 2.0.0 (2022-08-24)
# 2.0.0 (2022-09-02)

### Features
* add supports of sorting and filtering to iot-table. ([commit hash TBA]())
* (**breaking API changes**) iot-table now uses AWS-UI's table components (wrapped as a separated [table package](https://github.com/awslabs/iot-app-kit/blob/main/packages/table)) instead of Synchro-chart's table component.
Because of this change, we have new APIs for iot-table component. Check this [documentation](https://github.com/awslabs/iot-app-kit/blob/main/docs/Table.md) for more information about new APIs and migration from old APIs.

### BREAKING CHANGES
* `@iot-app-kit/components/iot-table` now uses AWS-UI's table components (wrapped as a separated [table package](https://github.com/awslabs/iot-app-kit/blob/main/packages/table)) instead of Synchro-chart's table component.
Because of this change, we have new APIs for `iot-table` component. Check this [documentation](https://github.com/awslabs/iot-app-kit/blob/main/docs/Table.md) for more information about new APIs and migration from old APIs.
* At current version (v2.0.0), `iot-table` does **NOT** support viewport groups. It will be added in a later version.


# 1.4.0 (2022-06-09)
Expand Down
3 changes: 3 additions & 0 deletions docs/Table.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ The table component provides a compact form for viewing one or more data streams

To migrate from previous API, check [Migrate from previous API](#migrate-from-previous-api)

**Note:**
Current version (v2.0.0), `iot-table` component does **NOT** support viewport groups. It will be added in a later version.

## Examples

#### React component example
Expand Down
9 changes: 6 additions & 3 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# 2.0.0 (2022-08-24)
# 2.0.0 (2022-09-02)

### Features
* add supports of sorting and filtering to iot-table. ([commit hash TBA]())
* (**breaking API changes**) iot-table now uses AWS-UI's table components (wrapped as a separated [table package](https://github.com/awslabs/iot-app-kit/blob/main/packages/table)) instead of Synchro-chart's table component.
Because of this change, we have new APIs for iot-table component. Check this [documentation](https://github.com/awslabs/iot-app-kit/blob/main/docs/Table.md) for more information about new APIs and migration from old APIs.

### BREAKING CHANGES
* `@iot-app-kit/components/iot-table` now uses AWS-UI's table components (wrapped as a separated [table package](https://github.com/awslabs/iot-app-kit/blob/main/packages/table)) instead of Synchro-chart's table component.
Because of this change, we have new APIs for `iot-table` component. Check this [documentation](https://github.com/awslabs/iot-app-kit/blob/main/docs/Table.md) for more information about new APIs and migration from old APIs.
* At current version (v2.0.0), `iot-table` does **NOT** support viewport groups. It will be added in a later version.

# 1.5.0 (2022-07-09)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ export class IotReactTable {

@Element() host: HTMLElement;

componentWillLoad() {}

componentDidLoad() {
this.componentDidUpdate();
}
Expand Down
4 changes: 3 additions & 1 deletion packages/components/src/components/iot-table/iot-table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,11 @@ export class IotTable {
)
);
}
componentWillRender() {
this.messages = merge(DefaultTableMessages, this.messageOverrides);
}

componentWillLoad() {
this.messages = merge(DefaultTableMessages, this.messageOverrides);
this.buildProvider();
}

Expand Down

0 comments on commit 735bba8

Please sign in to comment.