Npm workspaces #203
Closed
Npm workspaces #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-UI internal code name is mentioned in the readme.
Update reference to code name
boweihan
suggested changes
Aug 11, 2022
There was a problem hiding this comment.
Thanks for helping with this change!
There are a few instances of documentation that still use yarn commands - for example, docs/GettingStarted.md, README.md, and our npm-publish.yml workflow. Could probably just do a global find and replace for these instances.
| 5. Point to valid SiteWise resources | ||
|
|
||
| Alter the file `siteWiseQueries` within `@iot-app-kit/components` to point to valid SiteWise asset properties for the accounts credentials from the prior step. |
There was a problem hiding this comment.
dunno if it's just GH, but the spacing of these descriptions look inconsistent (new line here, vs. tab above and below).
docs/development.md
Outdated
| @@ -3,18 +3,44 @@ | |||
| ### Environment setup | |||
|
|
|||
| Iot-App-Kit runs on node and uses yarn for package management. Specific versions are required in order to keep builds working with the current monorepo tooling. | |||
There was a problem hiding this comment.
Remove yarn from this statement
|
make sure to clean up the commit history (which is considered part of the review) |
Merged
|
Closing this and rolling it into #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes dev dependencies on
yarnandlernaand just uses npm workspaces.Tests
[Include a link to the passing GitHub action running the test suite here.]
Legal
This project is available under the Apache 2.0 License.