Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up non_domain_separated_hpke_encrypt_decrypt cfgs #254

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

emarteca
Copy link
Contributor

Cleaning up the cfgs so users can use non_domain_separated_hpke_encrypt_decrypt without ffi feature enabled

In the current state, the cfgs for the non_domain_separated_hpke_encrypt_decrypt flagged-out functions are configured such that they can only be used if a user has the ffi feature also enabled. This requires a dependency on safer_ffi_gen. (This is my mistake, for how I configured these)

This PR just changes the configuration to remove this dependency, so users can use the non_domain_separated_hpke_encrypt_decrypt functions even without ffi.

@emarteca emarteca requested a review from a team as a code owner February 14, 2025 22:53
mulmarta
mulmarta previously approved these changes Feb 17, 2025
Copy link
Contributor

@mulmarta mulmarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW you can just move functions out of the FFI impl block, then you don't care about "ffi" features

@tomleavy tomleavy merged commit 930bde0 into awslabs:main Mar 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants