Disallow append on non-express buckets #1297
Draft
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
force-pushed
the
disallow-append-on-non-express
branch
from
5bc24f7 to
d630215
Compare
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
requested changes
Mar 4, 2025
There was a problem hiding this comment.
just some minor things.
I think the logging is important, in case there's ever any changes to the way customers access S3 Express One Zone. That will provide a pointer that the logic has updated, and prompt to check for an update to Mountpoint.
One thing making me a little uncomfortable is that we don't have any tests for the S3Personality type. I wonder if its worth writing some quick ones that check for a basic endpoint config and bucket name, do we get the expected personality? i.e. here's a directory bucket name, yes it maps correct. here's a bucket name and an outposts endpoint, yes it maps correctly.
mountpoint-s3/src/cli.rs
Outdated
Comment on lines
880
to
887
| if args.incremental_upload && !matches!(s3_personality, S3Personality::ExpressOneZone) { | ||
| return Err(anyhow!( | ||
| "--incremental-upload is only supported for S3 Express One Zone buckets" | ||
| )); | ||
| } |
There was a problem hiding this comment.
This should be below the log on line 887 that describes the detected bucket type
mountpoint-s3/CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## Unreleased | |||
|
|
|||
| ### Breaking changes | |||
|
|
|||
| * Disallow the usage of `--incremental-upload` command-line argument on non S3 Express buckets ([#1297](https://github.com/awslabs/mountpoint-s3/pull/1297)). | |||
There was a problem hiding this comment.
very nitpick: the period should be before the PR link to be consistent with prev changelog.
(only putting this since we need to make the other change)
mountpoint-s3/src/cli.rs
Outdated
Comment on lines
880
to
887
| if args.incremental_upload && !matches!(s3_personality, S3Personality::ExpressOneZone) { | ||
| return Err(anyhow!( | ||
| "--incremental-upload is only supported for S3 Express One Zone buckets" | ||
| )); | ||
| } |
There was a problem hiding this comment.
I think the personality check should live in the impl of S3Personality to match things like is_list_ordered, etc..
i.e. is_append_supported(&self)
passaro
reviewed
Mar 4, 2025
mountpoint-s3/src/cli.rs
Outdated
| @@ -877,6 +877,12 @@ where | |||
|
|
|||
| let (client, runtime, s3_personality) = client_builder(&args)?; | |||
|
|
|||
| if args.incremental_upload && !matches!(s3_personality, S3Personality::ExpressOneZone) { | |||
| return Err(anyhow!( | |||
| "--incremental-upload is only supported for S3 Express One Zone buckets" | |||
There was a problem hiding this comment.
This is what we use in docs:
Suggested change
| "--incremental-upload is only supported for S3 Express One Zone buckets" | |
| "--incremental-upload is only supported on directory buckets in S3 Express One Zone" |
passaro
reviewed
Mar 4, 2025
added 3 commits
March 7, 2025 15:37
Signed-off-by: Vlad Volodkin <[email protected]>
Signed-off-by: Vlad Volodkin <[email protected]>
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
force-pushed
the
disallow-append-on-non-express
branch
from
d630215 to
b5362e6
Compare
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
vladem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Vlad Volodkin <[email protected]>
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
vladem
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail early (on mount) with a descriptive error message, when
--incremental-uploadflag is used with standard buckets. We've seen in #1268 when an error reported on flush can be ignored by certain workloads.Decision is made based on endpoint resolution infer_s3_personality. This may erroneously assume that the bucket is S3 Standard if either endpoint resolution failed or
auth_schemecan not be parsed. In case of an error user may bypass it by specifying--bucket-type=directoryflag.As an alternative, we can infer if the bucket is a directory bucket from the name: docs. Then we can assume that all directory buckets support
--incremental-upload.Does this change impact existing behavior?
Yes,
mount-s3 s3-standard-bucket <folder> --incremental-uploadwill start failing on mount.Does this change need a changelog entry? Does it require a version change?
Yes, added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).