Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python lints to CI #1301

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

dannycjones
Copy link
Contributor

Before this change, there is no linting or style checks enforced on Python code outside of manual review.

This change introduces both using Ruff, a linter/checker written by the same organization owning uv which we use as the package manager/runner in benchmark/ project.

Does this change impact existing behavior?

No change to Mountpoint. No functional changes to the Python scripts. Two new GitHub CI jobs are introduced to add checks on the Python code.

Does this change need a changelog entry? Does it require a version change?

No, no impact to Mountpoint itself nor its crates.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

Signed-off-by: Daniel Carl Jones <[email protected]>
@dannycjones dannycjones requested a review from muddyfish March 4, 2025 15:19
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 15:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 5, 2025 13:34 — with GitHub Actions Inactive
@dannycjones dannycjones requested a review from sahityadg March 5, 2025 13:36
@dannycjones dannycjones enabled auto-merge March 5, 2025 13:36
@dannycjones dannycjones added this pull request to the merge queue Mar 5, 2025
Merged via the queue into awslabs:main with commit 3246e7f Mar 5, 2025
26 checks passed
@dannycjones dannycjones deleted the add-python-checks branch March 5, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants