Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a tenantRegistrationId column to tenantManagementTable #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hoseong-Seo
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

  • Tenant management table lacks tenantRegistrationId
  • SaaS provider UI (Admin) should display tenant information
  • Tenant removal API call from UI is hindered without tenantRegistrationId

Description of changes

The create_tenant_registration of Tenant Registration Lambda.

  • Add tenantRegistrationId value to tenant_data dictionary
  • Removed tenantRegistrationId from __create_control_plane_event

Description of how you validated changes

  • Tenant Removal test from UI.

Checklist

  • My code adheres to the CONTRIBUTING GUIDE
  • I have updated the relevant documentation (if applicable).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@suhussai suhussai force-pushed the add-tenant-registration-id branch from 51d4e2a to 5f410bf Compare March 6, 2025 20:40
Copy link
Contributor

@suhussai suhussai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hoseong-Seo , thanks for the update! Can you also update the sample onboarding event in the README so that it has the latest changes? It's here:

```json
{
"source": "controlPlaneEventSource",
"detail-type": "onboardingRequest",
"detail": {
"tenantId": "guid string",
"tenantName": "tenant$RANDOM",
"email": "[email protected]",
"tier": "basic",
"tenantStatus": "In progress"
}
}
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants