-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cypress issues #10
Conversation
make sure to add the some of the new snapshots are locking in style regressions, is there a way we can make this CR with less snapshot image changes so that we ensure that the snapshots are correct? |
Could you point which snapshots has style regression, I checked them all and they all seem to be from name changes? But I might have might some. I actually think I might have to remove the old ones out. |
Oh actually I think I could just move some of the old ones to the new folders and rerun the snaps to see the diff. Let me that and I think will point me to style regression. |
Okay, I moved the old screenshot over to the proper folder. No new screenshot generated here. I still get couple of 0.02 - 0.05% diff failures will leave it at that for now.
|
Description of changes:
awsui
stylewebpackComplilation
errorNote:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.