Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't convert Clojure values to JS values automatically in interop #602

Closed
borkdude opened this issue Aug 7, 2021 · 2 comments
Closed

Comments

@borkdude
Copy link
Collaborator

borkdude commented Aug 7, 2021

E.g. this doesn't work correctly because of it:

(.then (.resolve js/Promise {:a 1}) (clojure.core/fn [{:keys [:a] :as m}] a))

/cc @jeroenvandijk I'm changing this behavior, I didn't realize SCI was doing this, but just FYI, in case you're relying on it somewhere.

@jeroenvandijk
Copy link
Contributor

@borkdude Thanks for the heads up!

I'm not actively using this as far as I know. I was experimenting mostly and for a reason I don't remember this was how I solved it. This was last year when it was probably just me trying some first things. I'm sure there are more people pushing the JS Sci limits now!

Also I don't remember this line in interop.cljc

I'll update one project to the new Sci soon and see what happens :)

@borkdude
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants