Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Var and Namespace type via sci.lang #755

Closed
borkdude opened this issue May 25, 2022 · 2 comments
Closed

Expose Var and Namespace type via sci.lang #755

borkdude opened this issue May 25, 2022 · 2 comments

Comments

@borkdude
Copy link
Collaborator

This allows SCI configuration to make Clojure code that refers to clojure.lang.Var and (Namespace) and extends protocols to it to work by doing:

{:classes {'clojure.lang.Var sci.lang.SciVar}}
@borkdude
Copy link
Collaborator Author

cc @frenchy64

@borkdude
Copy link
Collaborator Author

I came across one occurrence of sci.impl.SciVar in the nextjournal source with extend-type. Moving the type to sci.lang will be breaking but at least from then on, it's public and should not cause any breakage.

Screenshot 2022-05-27 at 16 52 38

cc @mk

borkdude added a commit that referenced this issue May 30, 2022
@borkdude
#755: make sci.lang.Var public (#759)
fd6f331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@borkdude