-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling meta on records should exclude preserved own metadata? #819
Comments
Previously this was because record was just a regular map and metadata indicated that it was considered a record in SCI, but this implementation has changed and we may be able to get rid of this. |
Yeah, I was somewhat guessing the current situation from reading this TODO. |
How critical is this issue for you? |
Not so critical. |
The way I usually write tests like that (especially in clj-kondo test cases) is to assert that the result has at least the expected keys, but can contain more, so that when adding new keys, existing tests don't break. But I will leave this open and see when it can be fixed eventually. |
Should be fixed now. Fix also pushed to babashka. |
Great! Thanks!! |
Thanks for sponsoring :)
On Sun, 23 Oct 2022 at 15:38, Shogo Ohta ***@***.***> wrote:
Great! Thanks!!
I'm amazed every time I see how productive you are 😳
—
Reply to this email directly, view it on GitHub
<#819 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFSBVOZTGOIQY6IZBQM5TWEU5VTANCNFSM6AAAAAARLF47T4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
version
The current head of the master branch (207e994)
platform
Clojure CLI version 1.11.1.1165
macOS 12.6
problem & repro
When calling the
meta
function on a record object, you'll get metadata with the record's preserved own metadata merged:Is this the intended behavior or one of the limitations in the current record implementation?
expected behavior
Expected
(meta (with-meta x m)) = m
to hold for any validx
andm
.The text was updated successfully, but these errors were encountered: