chore: Add IBC and Bank transfer enabler on EndBlocker #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
|
|
||
| // EnableTransfersHeight TODO: Set this to the height for mainnet once it gets closer to launch. | ||
| const EnableTransfersHeight = 10 |
There was a problem hiding this comment.
one thing I wonder is how to best disable it on testnet ? maybe build flag which on testnet sets it up math.MaxInt and on mainnet to desired value ? we already use BABYLON_BUILD_OPTIONS="testnet" flag to differentiate binary for testnet and mainnet 🤔
There was a problem hiding this comment.
One possible approach which is easy and straightforward is to restrict the handler to run only on a specific chain id. Since chain ids will be different between testnet and mainnet we can just check ctx.ChainID.
There was a problem hiding this comment.
oh true, sounds like good idea 👍 then we need to quickly decide on chain-id for mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new top level
EndBlockerto enable IBC transfers and bank transfers at a certain hight still TBD.