Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: align adaptor sig impl with Blockstream spec #671

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Mar 12, 2025

Resolves https://github.com/babylonlabs-io/pm/issues/279
Resolves https://github.com/babylonlabs-io/pm/issues/281

This PR implements the adaptor signature following the Blockstream spec @kwantam. In particular, this PR

  • aligns all structs/functions to the spec
  • tests the impl against the test vectors in the spec

@SebastianElvis SebastianElvis marked this pull request as ready for review March 12, 2025 06:07
Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! though lets wait for second pair of eyes before merging.

@gitferry
Copy link
Member

sorry for being late here. I will take a look tmr as seems a lot to consume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants