chore: Validate pop cmd #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
approved these changes
Jan 24, 2025
cmd/stakercli/pop/pop.go
Outdated
| @@ -67,7 +75,7 @@ var generateCreatePopCmd = cli.Command{ | |||
| cli.StringFlag{ | |||
| Name: btcNetworkFlag, | |||
| Usage: "Bitcoin network on which staking should take place (testnet3, mainnet, regtest, simnet, signet)", | |||
| Value: "testnet3", | |||
| Value: "main", | |||
There was a problem hiding this comment.
not a blocker, but imo commands by defaults should use testnets and act of acting on mainnet should be concious choice of the operator
cmd/stakercli/pop/pop.go
Outdated
|
|
||
| secp256SigBase64, err := base64.StdEncoding.DecodeString(babySigOverBTCPk) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
lets wrap the error
cmd/stakercli/pop/pop.go
Outdated
| babySignBtcDoc := staker.NewCosmosSignDoc(babyAddr, base64Bytes) | ||
| babySignBtcMarshaled, err := json.Marshal(babySignBtcDoc) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
lets wrap the error
cmd/stakercli/pop/pop.go
Outdated
| ArgsUsage: "<path-to-pop.json>", | ||
| } | ||
|
|
||
| type ValidationResult struct { |
cmd/stakercli/pop/pop.go
Outdated
|
|
||
| bech32cosmosAddressString, err := sdk.Bech32ifyAddressBytes(babyPrefix, sdkAddress.Bytes()) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get babylon address bytes") |
|
|
||
| var popsToVerify = []staker.Response{ | ||
| { | ||
| BabyAddress: "bbn1xjz8fs9vkmefdqaxan5kv2d09vmwzru7jhy424", |
There was a problem hiding this comment.
just a question, as I assume this data was generated by generate pop command ?
There was a problem hiding this comment.
Ideally yes, but that would require some e2e tests to set up wallet, generate btc account, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
generate-create-popoutput the result to a JSON filevalidatepop cmd which takes the pop JSON file and verify pop