bump babylon v1.0.0-rc.4 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KonradStaniec
commented
Jan 28, 2025
KonradStaniec
commented
- bumps babylon and fixes conflicts
Lazar955
approved these changes
Jan 28, 2025
| @@ -512,7 +511,7 @@ func ValidateConfig(cfg Config) (*Config, error) { | |||
|
|
|||
| // Add default port to all RPC listener addresses if needed and remove | |||
| // duplicate addresses. | |||
| cfg.RPCListeners, err = lncfg.NormalizeAddresses( | |||
| cfg.RPCListeners, err = NormalizeAddresses( | |||
There was a problem hiding this comment.
Why the need to introduce this, what has changed?
There was a problem hiding this comment.
In new version of lnd , the lncfg package brings some dependency which require custom proto additions and without them compilation ends with:
../../../go/pkg/mod/github.com/lightningnetwork/[email protected]/lnrpc/rpc_utils.go:32:3: unknown field UseHexForBytes in struct literal of type protojson.MarshalOptions
../../../go/pkg/mod/github.com/lightningnetwork/[email protected]/lnrpc/rpc_utils.go:40:3: unknown field UseHexForBytes in struct literal of type protojson.UnmarshalOptions
I tried use this custom proto package (via replace) but then it does not contains custom stuff from cosmos-sdk.
Easiest way around it was, to remove this dependency and copy paste required code.
RafilxTenfen
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.