feat: implement of btc-staker improvement 107 (#134) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: remove watch-staking endpoint, post-approval flow * feat: remove db fields - state, fpkey and pop * feat: update CHANGELOG * feat: remove stakingoutputIdx, btcTxHash. refactoring UnbondingTxData and etc * feat: remove confirmation fields and modify WithdrawableTransactions * feat: cleanup codes including comments, error wrapping etc. * feat: change WithdrawableTransactions logic and set pagination
| @@ -131,10 +131,6 @@ var stakeCmd = cli.Command{ | |||
| Usage: "Staking time in BTC blocks", | |||
| Required: true, | |||
| }, | |||
| cli.BoolFlag{ | |||
There was a problem hiding this comment.
why remove this option?
There was a problem hiding this comment.
because after this pr staker will only support two flows:
- pre-registration flow
- and phase-1 / phase-2 transition flow (which is handled by separate command)
There is no longer post-registration flow, which was source of complexity and required a lot of state in DB.
RafilxTenfen
approved these changes
Feb 19, 2025
Co-authored-by: RafilxTenfen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wnjoon and b-harvest contribution - simplifing btc-staker program greatly
feat: remove watch-staking endpoint, post-approval flow
feat: remove db fields - state, fpkey and pop
feat: update CHANGELOG
feat: remove stakingoutputIdx, btcTxHash. refactoring UnbondingTxData and etc
feat: remove confirmation fields and modify WithdrawableTransactions
feat: cleanup codes including comments, error wrapping etc.
feat: change WithdrawableTransactions logic and set pagination