chore: use babylon params instead of global parameters #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
changed the title
RafilxTenfen
changed the title
RafilxTenfen
commented
Mar 10, 2025
| @@ -55,9 +46,9 @@ var checkDaemonHealthCmd = cli.Command{ | |||
| Usage: "Check if staker daemon is running.", | |||
| Flags: []cli.Flag{ | |||
| cli.StringFlag{ | |||
| Name: stakingDaemonAddressFlag, | |||
| Name: helpers.StakingDaemonAddressFlag, | |||
There was a problem hiding this comment.
just moved a few duplicate flags to get from helpers
RafilxTenfen
commented
Mar 10, 2025
| @@ -138,14 +129,14 @@ var stakeCmd = cli.Command{ | |||
| var stakeFromPhase1Cmd = cli.Command{ | |||
| Name: "stake-from-phase1", | |||
| ShortName: "stfp1", | |||
| Usage: "\nstakercli daemon stake-from-phase1 [fullpath/to/global_parameters.json]" + | |||
| Usage: "\nstakercli daemon stake-from-phase1" + | |||
There was a problem hiding this comment.
removed the expected path of global parameters
RafilxTenfen
commented
Mar 10, 2025
| Usage: "Inclusion height of the staking transactions. Necessary to chose correct global parameters for transaction", | ||
| Required: true, | ||
| Required: false, |
There was a problem hiding this comment.
inclusion height is not required anymore, it can load from the btc node
…from create-phase1-unbonding-transaction and create-phase1-withdrawal-transaction
RafilxTenfen
commented
Mar 10, 2025
| StakingParams []BtcStakingParams `json:"staking_params"` | ||
| } | ||
|
|
||
| type BtcStakingParams struct { |
There was a problem hiding this comment.
the only params needed to parse the staking tx
walletcontroller/interface.go
Outdated
| @@ -114,3 +116,16 @@ func StkTxV0ParsedWithBlock( | |||
|
|
|||
| return parsedStakingTx, notifierTx, status, nil | |||
| } | |||
|
|
|||
| func ParseV0StakingTx( | |||
There was a problem hiding this comment.
still let the option to validate the tag if it is provided
…er based on the BTC block height
KonradStaniec
approved these changes
Mar 12, 2025
RafilxTenfen
added a commit
that referenced
this pull request
Mar 12, 2025
Merged
RafilxTenfen
added a commit
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stakercli daemon stake-from-phase1use babylon params instead of global parametersstakercli transaction create-phase1-unbonding-transactionandstakercli transaction create-phase1-withdrawal-transactionadd the option for the flag "tx-inclusion-height" be optional (load from the btc node if not set)