feat: add basic auth to stakerd routes #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func BasicAuthMiddleware(expUsername, expPwd string) func(http.HandlerFunc) http.HandlerFunc { | ||
| return func(next http.HandlerFunc) http.HandlerFunc { | ||
| return func(w http.ResponseWriter, r *http.Request) { | ||
| user, pass, ok := r.BasicAuth() |
There was a problem hiding this comment.
I wonder whether we can take some insipiration in how auth is done from btcd - https://github.com/btcsuite/btcd/blob/cba88226f49d5162c83c3edb562cc926edb4a87f/rpcserver.go#L4150 🤔
There was a problem hiding this comment.
This seems more complex, but I can those maps to the staker service and have the BasicAuthMiddleware as a method to check basic auth
authsha [sha256.Size]byte
limitauthsha [sha256.Size]byte
KonradStaniec
approved these changes
Mar 12, 2025
Merged
RafilxTenfen
added a commit
that referenced
this pull request
Mar 13, 2025
* feat: add basic auth to stakerd routes * chore: add #155 to cl * chore: warn user about env * chore: RPC from cometbft to add basic auth middleware * fix: lint * chore: add auth to stakercli requests * chore: removed print for load .env * chore: removed opaque set * chore: add auth middleware to / as well * chore: add comment for auth Rpc client * chore: add auth env to manager * chore: use vars * fix: add client auth to e2e test
Merged
RafilxTenfen
added a commit
that referenced
this pull request
Mar 13, 2025
* feat: add basic auth to stakerd routes (#155) * feat: add basic auth to stakerd routes * chore: add #155 to cl * chore: warn user about env * chore: RPC from cometbft to add basic auth middleware * fix: lint * chore: add auth to stakercli requests * chore: removed print for load .env * chore: removed opaque set * chore: add auth middleware to / as well * chore: add comment for auth Rpc client * chore: add auth env to manager * chore: use vars * fix: add client auth to e2e test * chore: add env auth vars to StartManagerStakerApp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.env.exampleand tip on readme to add AUTH envsCloses: #153