feat: move stakerapp creation from main to stakerservice #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the
// TODO: consider moving this to stakerservice
comment inmain.go
.Changes:
NewStakerServiceFromConfig
function.NewStakerServiceFromConfig
, theStakerService
is now created after callingNewStakerAppFromConfig
.Benefits of this refactoring:
main.go
now primarily serves as a high-level coordinator, reducing its responsibilities and simplifying the code.stakerApp
instance is created will no longer require modifications tomain.go
.stakerApp
instance withinstakerService
, mock objects can be injected more easily for testing.stakerService
directly instantiatestakerApp
clarifies the dependency relationship between the components.