Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HMAC authentication for covenant emulator and covenant signer #109

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

Vvaradinov
Copy link
Contributor

Implements the optional HMAC middleware as described here - https://github.com/babylonlabs-io/pm/pull/261

Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good 👍

It would be great to do some test with aws secret manager with collaboration of @babylon-devops team

(also please update changelog)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Vvaradinov Vvaradinov merged commit 1053ca8 into main Mar 11, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants