Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to get node-addon-api >=7.0.0 to fix builds on node 20.12.0 #2751

Merged
merged 10 commits into from
Apr 9, 2024
Merged

Update dependencies to get node-addon-api >=7.0.0 to fix builds on node 20.12.0 #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e268950
Mark bin/dev & bin/run as executable
thgreasi Apr 8, 2024
1a246a9
Update etcher-sdk to v9.0.8
thgreasi Apr 8, 2024
e7869f4
Update balena-device-init to v7.0.1
thgreasi Apr 9, 2024
933eacf
Update resin-cli-visuals to v2
thgreasi Apr 8, 2024
2cba3bb
Update resin-cli-form to v3
thgreasi Apr 8, 2024
c6827ee
Update balena-preload to v15.0.4
thgreasi Apr 9, 2024
be682c7
Drop the keep-alive package in favor of node's setKeepAlive defaults
thgreasi Apr 9, 2024
4811031
Update @oclif/core to 3.26.2
thgreasi Apr 9, 2024
98514ce
Deduplicate dependencies
thgreasi Apr 9, 2024
04b4444
Update expected build warning tests
thgreasi Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified bin/dev.js
100644 → 100755
View file
Open in desktop
Empty file.
Empty file modified bin/run.js
100644 → 100755
View file
Open in desktop
Empty file.
13 changes: 0 additions & 13 deletions lib/utils/device/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
* limitations under the License.
*/
import * as _ from 'lodash';
import type { NodeJSSocketWithFileDescriptor } from 'net-keepalive';
import * as os from 'os';
import * as request from 'request';
import type * as Stream from 'stream';

Expand Down Expand Up @@ -214,17 +212,6 @@ export class DeviceAPI {
}
try {
res.socket.setKeepAlive(true, 1000);
if (os.platform() !== 'win32') {
const NetKeepalive = await import('net-keepalive');
// Certain versions of typescript won't convert
// this automatically
const sock = res.socket as any as NodeJSSocketWithFileDescriptor;
// We send a tcp keepalive probe once every 5 seconds
NetKeepalive.setKeepAliveInterval(sock, 5000);
// After 5 failed probes, the connection is marked as
// closed
NetKeepalive.setKeepAliveProbes(sock, 5);
}
} catch (error) {
reject(error);
}
Expand Down
Loading
Loading