Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docker-modem and dockerode to avoid regression #2916

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kb2ma
Copy link
Contributor

@kb2ma kb2ma commented Feb 25, 2025

We are seeing a test failure in the "balena build" tests when dedupe dependencies on current master. The issue looks to be a regression in docker-modem, as described in the offending PR, which was incorporated into docker-modem v5.0.6.

This PR pins docker-modem on v5.0.5 and dockerode on v4.0.3. The latest dockerode release, v4.0.4, also depends on docker-modem v5.0.6.

Error:    Build failed.
expected [ [ 'platform', 'linux/amd64' ],
  [ 'buildargs', { BARG1: 'b1', barg2: 'B2' } ],
  [ 'cachefrom', 'my/img1' ],
  [ 'cachefrom', 'my/img2' ],
  [ 't', 'basic_main' ],
  [ 'labels', '' ] ] to have the same members as [ [ 't', 'basic_main' ],
  [ 'buildargs', { BARG1: 'b1', barg2: 'B2' } ],
  [ 'labels', '' ],
  [ 'platform', 'linux/amd64' ],
  [ 'cachefrom', [ 'my/img1', 'my/img2' ] ] ]

Change-type: patch
Signed-off-by: Ken Bannister <[email protected]>
@kb2ma kb2ma changed the title Pin docker-modem and dockerode to avoid regression Do not merge: Pin docker-modem and dockerode to avoid regression Feb 25, 2025
@kb2ma kb2ma marked this pull request as ready for review February 25, 2025 17:14
@kb2ma kb2ma merged commit 00b4d57 into master Feb 25, 2025
59 checks passed
@kb2ma kb2ma deleted the pin_docker-modem_regression branch February 25, 2025 17:16
@kb2ma kb2ma changed the title Do not merge: Pin docker-modem and dockerode to avoid regression Pin docker-modem and dockerode to avoid regression Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants