Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove folder dynamodb_local as it increases significantly the repository size #135

Closed
adrian7 opened this issue Mar 11, 2018 · 2 comments
Closed

Remove folder dynamodb_local as it increases significantly the repository size #135

adrian7 opened this issue Mar 11, 2018 · 2 comments
Labels
enhancement

Comments

@adrian7
Copy link
Contributor

adrian7 commented Mar 11, 2018

I think we should remove the folder containing dynamodb_local, and add instead instructions on how to get DynamoDb running locally, or provide a docker-compose file with the service.
@baopham
Copy link
Owner

baopham commented Mar 12, 2018

👌 I'll think of something. Thanks for the suggestions.

baopham added a commit that referenced this issue Apr 7, 2018
@baopham
Exclude dynamodb_local and tests for archive
bfd2ad9 
Related #135
@baopham
Copy link
Owner

baopham commented Apr 7, 2018

I've made dynamodb_local excluded from archive so that the package is smaller when being installed. I still prefer to have it in the repo for now. It's more convenient (less step to setup for local development) for me or anyone who wants to contribute.

@baopham baopham closed this as completed Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrian7 @baopham